[SSSD] [PATCH] Support logrotate for SSSD DEBUG logs

Jakub Hrozek jhrozek at redhat.com
Tue Mar 2 15:00:10 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/26/2010 05:33 PM, Stephen Gallagher wrote:
> Nack.
> 
> This is partly my fault. update_monitor_config() is broken and
> dangerous. I thought I had disabled all access to it. I didn't realize
> it was still running with SIGHUP.
> 
> We disabled it a long while ago with the intent of fixing it eventually,
> but we ultimately decided that the downtime of a full restart was
> acceptable. I've been meaning to eliminate that code entirely.
> 

Stephen eliminated that code in a separate patch which has been acked,
so the attached patches are rebased on top of his.

> Also, the *_rotate_logs() calls are all identical. They should just be
> made into a monitor_common_rotate_logs() call similar to
> monitor_common_res_init().

Done. I originally wanted to keep functions local to the separate
process (and its function namespace) but I agree that code duplication
is bad.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuNJ/oACgkQHsardTLnvCWE+ACg6ft/7boIQU7BGeCHHeQy4GJm
/0EAmwcSn4TiYFP6ovJNQ1YPUDAUbkv/
=TY/5
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reopen-logs-when-SIGHUP-is-caught.patch
Type: text/x-patch
Size: 7267 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100302/48f34ca3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Package-example-logrotate-script.patch
Type: text/x-patch
Size: 2221 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100302/48f34ca3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reopen-logs-when-SIGHUP-is-caught.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100302/48f34ca3/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Package-example-logrotate-script.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100302/48f34ca3/attachment-0001.sig>


More information about the sssd-devel mailing list