[SSSD] [PATCH] Protect against segfault in remove_ldap_connection_callbacks

Simo Sorce ssorce at redhat.com
Fri Jun 18 13:56:19 UTC 2010


On Fri, 18 Jun 2010 09:48:11 -0400
Stephen Gallagher <sgallagh at redhat.com> wrote:

> [PATCH 1/2] Fix return value from remove_connection_callback()
> destructor
> 
> ldap_get_option() can only fail if the option we're removing has
> already been removed. It is sufficient to log this and continue.

ACK

> [PATCH 2/2] Protect against segfault in
> remove_ldap_connection_callbacks
> 
> If sdap_mark_offline() is called before a live connection is
> established, sdap_fd_events could be NULL, causing a segfault when
> remove_ldap_connection_callbacks() attempts to free the
> sdap_fd_events->conncb

ACK

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list