[SSSD] [PATCH] Protect against segfault in remove_ldap_connection_callbacks

Simo Sorce ssorce at redhat.com
Fri Jun 18 13:37:14 UTC 2010


On Thu, 17 Jun 2010 16:25:24 -0400
Stephen Gallagher <sgallagh at redhat.com> wrote:

> +    if (sh->sdap_fd_events) {
> +        ret = talloc_free(sh->sdap_fd_events->conncb);
> +        if (ret != 0) {
> +            return EIO;
> +        }
>  

NACK, it makes no sense for us to abort here, we have no way to recover.
And the destructor should never return error for conncb anyway, waiting
patch for both issues.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list