[SSSD] [PATCH] Remove the krb5_changepw_principal option

Stephen Gallagher stephen at gallagherhome.com
Tue Jun 15 10:18:22 UTC 2010


You are correct, David. Principal should be the correct spelling in
all places. We need to review this in the code before releasing 1.2.1.

On Jun 14, 2010, at 10:59 PM, David O'Brien <davido at redhat.com> wrote:

> Simo Sorce wrote:
>> On Fri, 11 Jun 2010 11:19:32 +0200
>> Jakub Hrozek <jhrozek at redhat.com> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 06/10/2010 09:54 PM, Simo Sorce wrote:
>>>> On Thu, 10 Jun 2010 20:34:13 +0200
>>>> Jakub Hrozek <jhrozek at redhat.com> wrote:
>>>>
>>>>>
>>>>> +#define SSSD_KRB5_CHANGEPW_PRINCIPLE
>>>>> "SSSD_KRB5_CHANGEPW_PRINCIPLE" +
>
> I'd like to bring this up only because I'm sure it's going to bite
> somebody eventually. "Principal" vs. "principle" - In this case it's
> not
> going to matter (you could call it anything), but I've seen numerous
> instances of these two spellings being mixed up in man pages, and if
> it
> makes it into an example then something is not going to work.
>
> David
>
>>>> shouldn't this be: "kadmin/changepw" ?
>>>>
>>> Yes, thank you, I replied to Stephen's review with the fixed patch.
>>>
>>>>> +                        discard_const_p(char,
>>>>> SSSD_KRB5_CHANGEPW_PRINCIPLE),
>>>>> +                        kr->options);
>>>>>
>>>> I really don't like the use of discard_const_p(), can you please
>>>> talloc_strdup() it ?
>>>>
>>> Done, but would you mind giving a couple of examples where
>>> discard_const_p() should or should not be used? It seems I don't
>>> quite
>>> understand it.
>>
>> IT should be used only when you are calling a system call that
>> takes a non-const and where you have a const value and you are
>> absolutely positive it will not be changed.
>>
>> In very rare other cases, so rare that discussing each of them is ok.
>>
>> Simo.
>>
>>
>>
>
>
> --
>
> David O'Brien
> Senior Technical Writer, Engineering Content Services
> Red Hat Asia Pacific Pty Ltd
> 193 North Quay, Brisbane
>
> "We couldn't care less about comfort. We make you feel good."
> Federico Minoli CEO Ducati Motor S.p.A.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list