[SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

Sumit Bose sbose at redhat.com
Thu Jun 10 09:48:17 UTC 2010


On Wed, Jun 09, 2010 at 12:21:15PM -0400, Stephen Gallagher wrote:
> On 06/09/2010 11:09 AM, Sumit Bose wrote:
> >
> >NACK, with this patch the backend returns with pd->pam_status not set.
> >Please change it to something like:
> >
> >     pd->pam_status = PAM_SYSTEM_ERR;
> >     ipa_auth_reply(be_req, DP_ERR_FATAL, pd->pam_status);
> >
> >and call
> >
> >     pd = talloc_get_type(be_req->req_data, struct pam_data);
> >
> >at the very beginning of ipa_auth().
> >
> 
> New version of this patch attached.
> 
> For the record, in the future we should rethink how this works. I
> don't like carrying around a "magic" pam_data value that needs to be
> updated separately from calling ipa_auth_reply(). It's not obvious,
> and that makes it unsafe for new developers.
> 
> -- 
> Stephen Gallagher
> RHCE 804006346421761
> 
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/

ok

ACK to this and to 0002-0008, too.

bye,
Sumit



More information about the sssd-devel mailing list