[SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

Stephen Gallagher sgallagh at redhat.com
Wed Jun 9 14:53:55 UTC 2010


All patches apply to both master and sssd-1-2.

Patch 0001: https://fedorahosted.org/sssd/ticket/506
Avoid potential NULL dereference
There was no sense in assigning the value to state->pd->pam_status
here at all.

Patch 0002: https://fedorahosted.org/sssd/ticket/507
Properly handle missing originalMemberOf entry in initgroups
Failing to return after the tevent_req_post() here can result in a
null-pointer dereference (along with other hard-to-track bugs)

Patch 0003: https://fedorahosted.org/sssd/ticket/514
Don't leak directory access resources on errors in directory_list()

Patch 0004: https://fedorahosted.org/sssd/ticket/523
Check the correct variable for NULL after creating timer
In several places, we were creating a new timer and assigning it
to the tev variable, but then we were checking for NULL from the
te variable (which, incidentally, is guaranteed never to be NULL
in this situation)

Patch 0005: https://fedorahosted.org/sssd/ticket/524
Properly check that the timeout event was created for cleanup/enum
We need to make sure that if we didn't create the timeout, that we
cancel the request so there's no chance of ending up with two
enumerations/cleanups running simultaneously. We'll attempt to
reschedule later, if possible.

Patch 0006: https://fedorahosted.org/sssd/ticket/534
Check return code of hash_delete in proxy_child_destructor
We can't do much about an error here, but we should be reporting
it.

Patch 0007: https://fedorahosted.org/sssd/ticket/525
Eliminate unused variable from pc_init_timeout()

Patch 0008: https://fedorahosted.org/sssd/ticket/528
Make sure to close varargs before returning from a function

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-potential-NULL-dereference.patch
Type: text/x-patch
Size: 991 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Properly-handle-missing-originalMemberOf-entry-in-in.patch
Type: text/x-patch
Size: 1084 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Don-t-leak-directory-access-resources-on-errors-in-d.patch
Type: text/x-patch
Size: 1562 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Check-the-correct-variable-for-NULL-after-creating-t.patch
Type: text/x-patch
Size: 3090 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Properly-check-that-the-timeout-event-was-created-fo.patch
Type: text/x-patch
Size: 4818 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Check-return-code-of-hash_delete-in-proxy_child_dest.patch
Type: text/x-patch
Size: 1407 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Eliminate-unused-variable-from-pc_init_timeout.patch
Type: text/x-patch
Size: 1026 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Make-sure-to-close-varargs-before-returning-from-a-f.patch
Type: text/x-patch
Size: 1548 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100609/56bbb1e4/attachment-0007.bin>


More information about the sssd-devel mailing list