[SSSD] [PATCH] Add a missing return value

Sumit Bose sbose at redhat.com
Wed Jun 9 12:19:24 UTC 2010


On Wed, Jun 09, 2010 at 07:56:33AM -0400, Stephen Gallagher wrote:
> On 06/09/2010 06:52 AM, Sumit Bose wrote:
> > Hi,
> >
> > this patch should fix #521 by setting the unitialized return code to
> > EPERM.
> >
> 
> Ack.

sorry, EPERM is not the right return value here, because there is no
error in the current tevent request EOK is the correct value.

New version attached.

bye,
Sumit
> 
> -- 
> Stephen Gallagher
> RHCE 804006346421761
> 
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
-------------- next part --------------
From f2cd875697672ca598d365b370bdbf5fa35a560c Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 9 Jun 2010 12:42:10 +0200
Subject: [PATCH] Add a missing return value

---
 src/providers/krb5/krb5_auth.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/providers/krb5/krb5_auth.c b/src/providers/krb5/krb5_auth.c
index e3aaa18..5153550 100644
--- a/src/providers/krb5/krb5_auth.c
+++ b/src/providers/krb5/krb5_auth.c
@@ -710,6 +710,7 @@ struct tevent_req *krb5_auth_send(TALLOC_CTX *mem_ctx,
                 DEBUG(4, ("Password reset by root is not supported.\n"));
                 state->pam_status = PAM_PERM_DENIED;
                 state->dp_err = DP_ERR_OK;
+                ret = EOK;
                 goto done;
             }
             break;
-- 
1.7.0.1



More information about the sssd-devel mailing list