[SSSD] [PATCHES] Fix severe performance problems with initgroups

Simo Sorce ssorce at redhat.com
Fri Jul 30 13:49:30 UTC 2010


On Fri, 30 Jul 2010 09:08:52 -0400
Stephen Gallagher <sgallagh at redhat.com> wrote:

> I've added a new patch
> 0005-Copy-the-attrs-attribute-in-sysdb_search_user_by_nam.patch that
> fixes this.

NACK, the unbspoken rule for teven stype stuff is that if you pass down
something to a _send() function it *has* to stay around until the
corresponding _recv() function is called. That's why usually things are
allocated on the "state" variable.

By copying it, not only we waste resources, we also set us up for
further failures elsewhere.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list