[SSSD] [PATCHES] Fix severe performance problems with initgroups

Stephen Gallagher sgallagh at redhat.com
Fri Jul 30 13:08:52 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/30/2010 07:35 AM, Jakub Hrozek wrote:
> Nack, testing revealed crash when calling "id" on user who is not a
> member of any groups.


Thanks for catching this. It turned out that
sysdb_search_user_by_name_send() did not copy the passed-in value of
attrs, so when it went out of scope (being defined on the stack in
sdap_initgr_rfc2307_get_sysdb_groups())

I've added a new patch
0005-Copy-the-attrs-attribute-in-sysdb_search_user_by_nam.patch that
fixes this.

I also updated patch 0004-Add-dup_string_list-utility-function.patch to
make it take a const char ** and modified patch
0006-Add-sysdb_update_members-function.patch accordingly to avoid
compiler warnings.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkxSzuMACgkQeiVVYja6o6PDkgCfTc7f2Wr+V3qziZFLZSgPeDNH
7nEAn2YsHLGAB4SrA34BrpO8DkBlAyvT
=lrcj
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-sysdb_attrs_to_list-utility-function.patch
Type: text/x-patch
Size: 5483 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-diff_string_lists-utility-function.patch
Type: text/x-patch
Size: 16079 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-sysdb_group_dn_name-utility-function.patch
Type: text/x-patch
Size: 2101 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-dup_string_list-utility-function.patch
Type: text/x-patch
Size: 2002 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Copy-the-attrs-attribute-in-sysdb_search_user_by_nam.patch
Type: text/x-patch
Size: 1121 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Add-sysdb_update_members-function.patch
Type: text/x-patch
Size: 13176 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Clean-up-initgroups-processing-for-RFC2307.patch
Type: text/x-patch
Size: 10686 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-sysdb_attrs_to_list-utility-function.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-diff_string_lists-utility-function.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0001.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-sysdb_group_dn_name-utility-function.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0002.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-dup_string_list-utility-function.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0003.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Copy-the-attrs-attribute-in-sysdb_search_user_by_nam.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0004.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Add-sysdb_update_members-function.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0005.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Clean-up-initgroups-processing-for-RFC2307.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100730/73fff5a7/attachment-0006.sig>


More information about the sssd-devel mailing list