[SSSD] [PATCHES] Fix severe performance problems with initgroups

Stephen Gallagher sgallagh at redhat.com
Wed Jul 28 20:22:09 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/28/2010 04:19 PM, Simo Sorce wrote:
> On Wed, 28 Jul 2010 15:29:47 -0400
> Stephen Gallagher <sgallagh at redhat.com> wrote:

> If I read it right, here you are receiving the results from sysdb,
> therefore you should look for SYSDB_MEMBEROF, and not the name of the
> attribute of the remote LDAP server.


Oops, thanks for catching that. I saw that I was doing that elsewhere in
the code and fixed it, but I guess I missed this one.

> 
>> +    if(!groups || groups->num_values == 0) {
> 
> style issue again on if(

Gah, I don't know why I'm so inconsistent on that.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkxQkXEACgkQeiVVYja6o6N4pACcDuc3BfG0sLuYvXnw+webU1hC
xWcAn2ia94kd2qk1DiU1iWa13gfMUGZF
=Liyu
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list