[SSSD] [PATCH] Fix two problems with --as-needed

Stephen Gallagher sgallagh at redhat.com
Tue Jul 27 14:57:20 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/27/2010 10:54 AM, Jakub Hrozek wrote:
> On 07/27/2010 03:59 PM, Stephen Gallagher wrote:
>> On 07/27/2010 09:53 AM, Jakub Hrozek wrote:
>>> Hi,
>>> On Fedora, I saw two problems when building and using sssd with
>>> -Wl,--as-needed:
> 
>>> The configure-time check for HAVE_DBUS_WATCH_GET_UNIX_FD wasn't run
>>> correctly which resulted in using the deprecated DBus function and
>>> subsequent GCC warning. The other issue was that the  LDAP backend
>>> wouldn't start and complained about "libsss_ldap.so: undefined symbol:
>>> hash_error_string".
> 
>>> The attached patch addresses them. It is at least partial fix for #559.
> 
>>> 	Jakub
> 
> 
> 
>> Nack.
> 
>> You probably meant to change SAFE_LDFLAGS to SAFE_LIBS and make sure to
>> restore the original $LIBS state here.
> 
>> Right now you're overwriting whatever LIBS was before you started with
>> the value of LDFLAGS.
> 
> 
> Right, new patch attached
> 


Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkxO89AACgkQeiVVYja6o6NU0gCeMxTO+1JtqFhfqmay6X2k4Ssx
3yMAn34iex5l1GjB1e7e1Wk2KXwYcbF8
=Vr7R
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list