[SSSD] [PATCH] Validate keytab at startup

Stephen Gallagher sgallagh at redhat.com
Mon Jul 26 16:34:26 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/22/2010 11:39 AM, Jakub Hrozek wrote:
> On 07/22/2010 02:06 PM, Stephen Gallagher wrote:
>> Nack.
> 
>> sss_krb5_verify_keytab() should not be passed a memctx. No memory
>> created in this function is being passed back to the caller. It would be
>> much better to create a tmp_ctx (at the top-level) for the function and
>> talloc_free() that in the done: label. This will make it easier to
>> detect memory leaks with valgrind, as well.
> 
> 
> Fixed
> 

Nack. If an error is returned from krb5_init_context, the memory for
tmp_ctx is leaked.

Otherwise it looks good.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkxNuRIACgkQeiVVYja6o6MEUgCgmrLhBGFETpQMDQq6bM0resuF
y1oAniwccbMBEokanODh91sZJP2e4CQO
=cjaM
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list