[SSSD] [PATCH] Add syslog messages for LDAP GSSAPI bind

Stephen Gallagher sgallagh at redhat.com
Fri Jul 2 14:01:03 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/02/2010 09:37 AM, Dmitri Pal wrote:
> Nack
> 
> You are leaking entry in success scenario.
> I suggest a little bit cleaner approach:
> 
>     while((ret = krb5_kt_next_entry(context, keytab, &entry, &cursor))
> == 0){
>         krb5_unparse_name(context, entry.principal, &principal);
>         krb5_free_keytab_entry_contents(context, &entry);
>         if (strcmp(full_princ, principal) == 0) found = true;
>         free(principal);
>         if (found) break;
>     }

Good catch. Fixed.

> 
> And I think that if you have explicit syslog messages in case of
> failures it makes sense to have one also in the case krb5_kt_end_seq_get
> fails.
> 

Sure. It should hopefully never happen, but added nonetheless.


Thanks for the review! New patch attached.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkwt8R8ACgkQeiVVYja6o6OlhwCcCjAqAc7n1GvlQvT6x/icDm4q
3LEAniCZdLpA2GbryIDqXtiHiNJvcKMa
=4ag2
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-syslog-messages-for-LDAP-GSSAPI-bind.patch
Type: text/x-patch
Size: 4259 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100702/16aecd47/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-syslog-messages-for-LDAP-GSSAPI-bind.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100702/16aecd47/attachment.sig>


More information about the sssd-devel mailing list