[SSSD] [PATCH] Log TLS errors to syslog

Dmitri Pal dpal at redhat.com
Fri Jul 2 13:51:50 UTC 2010


Stephen Gallagher wrote:
> Also adds support for detecting LDAPS errors by adding a check for
> SDAP_DIAGNOSTIC_MESSAGE after ldap_search_ext()
>
> This should make debugging an initial setup easier, as the most common
> configuration errors will appear in /var/log/messages, instead of
> requiring the user to turn on the debug logs.
>
Visual ack with nitpicks:


+            syslog(LOG_ERR, "Could not start TLS. "
+                            "Check for certificate issues\n");


+            syslog(LOG_ERR, "Could not install TLS. "
+                            "Check for certificate issues\n");


1) Trailing dots are missing
2) Don't you want to print out the ldap_err2string(ret) anyways?
3) What does "install" TLS means? This message sounds confusing. What is
it that you are "installing"?




-------------------------

_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list