[SSSD] [PATCH] Add mandatory flag to SSSD config schema

Jakub Hrozek jhrozek at redhat.com
Mon Jan 11 14:58:04 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/07/2010 05:54 PM, Stephen Gallagher wrote:
> Address https://fedorahosted.org/sssd/ticket/349
> 
> 
> After a bit of thought, I decided to break this into two separate
> patches to make it more clear. New patches attached.
> 
> Patch 0002: Remove the explicit defaults where they're unneeded.

Ack

> Patch 0003: Implement the mandatory flag as in the previous patch.

Nack,

the schema adds ipa_hostname as mandatory service.

Also all of the {access,auth,chpass,id}_providers are marked as
mandatory - is that correct? A domain with just id and auth providers is
a perfectly valid one.

In the LDAP config, I think plain ldap_search_base should be marked as
mandatory, not the specialised ldap_{user,group}_search base - if these
are not set, the value of ldap_search_base is used.

IIRC the krb5_realm and krb5_kdcip is not strictly mandatory when using
the locator plugin, but I guess that the recommended use case would be
to put the info into our config, so these are probably fine.

The code itself looks fine to me.

	Jakub

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAktLPHwACgkQHsardTLnvCU6TQCfd6WfgCd/mF/6vg9ZOpv+SUxb
VUUAn1MOq3gBZWcRAM+3HYeI4/kBuWoz
=3CU5
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list