[SSSD] [PATCH] Better cleanup task handling

Jakub Hrozek jhrozek at redhat.com
Tue Feb 23 17:20:41 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/23/2010 06:03 PM, Simo Sorce wrote:
> This snipped is very confusing.
> It looks like ldap_cred_expiration should really be called
> login_cache_timeout, or what I am not understanding here?
> 

Yes, this is confusing. As you mentioned in the other mail, the name of
the new option was chosen badly, I'll change the variable along with the
option name.

> Can you also add a comment that explains the checks ?
> Given the special case (0 == unlimited) I think a comment would help a
> lot the casual reader understanding what is going on here.
> 

Yes, will do.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuEDmgACgkQHsardTLnvCWvrACdHvadW6OoFWyJrvj7nZvfCWNK
drQAnjQeuwQOKFALVqSJEtcF9SWGUJMr
=bqyn
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list