[SSSD] [PATCH] sss_groupshow improvements

Jakub Hrozek jhrozek at redhat.com
Wed Feb 10 12:21:58 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/10/2010 11:40 AM, Sumit Bose wrote:
+
+    subreq = group_show_recurse_send(state->root, state,
+                                     state->root,
+                                     group_members,
+                                     nmembers);
+    if (ret != EOK) {
+        tevent_req_error(req, ret);
+        return;
+    }
+    tevent_req_set_callback(subreq, group_show_recurse_done, req);
+}
+

> I think 'if (!subreq)' fits better here.

> bye,
> Sumit

Yes, a copy'n'paste error..thanks for catching that.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAktypOYACgkQHsardTLnvCWhSgCgg70cvJWvcKWA4YcCkA/W0qg4
KE8AoMki241t64LQ4Q5LF7Kz6aJZJgPV
=sqD0
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sss_groupshow-improvements.patch
Type: text/x-patch
Size: 32574 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100210/1694787a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sss_groupshow-improvements.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100210/1694787a/attachment.sig>


More information about the sssd-devel mailing list