[SSSD] [PATCH] sss_groupshow improvements

Sumit Bose sbose at redhat.com
Tue Feb 9 11:20:29 UTC 2010


On Mon, Feb 08, 2010 at 09:01:29PM +0100, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> This patch fixes the following issues:
>     * man page issues (#395)
>     * show info on MPGs (#396)
>     * recursively print indirect members (#397)
>     * the list of groupnames is comma separated (#398)
>     * output inconsistencies (#399)
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAktwbZkACgkQHsardTLnvCUl6gCffDSrlRrfr955H9o8Y55PteLz
> Kk8AoOk4Y1CgJuXXT4KcVulQDfMrkCko
> =38ve
> -----END PGP SIGNATURE-----

NACK

> +
> +    if (state->recursive == false) {
> +        /* if not recursive, just fill in names */
> +        state->root->group_members = talloc_array(state->root,
> +                                                  struct group_info *,
> +                                                  nmembers+1);
> +        for (i=0; group_members[i]; i++) {
> +            state->root->group_members[i] = talloc_zero(state->root,
> +                                                        struct group_info);

if there are no group members group_members==NULL.

bye,
Sumit



More information about the sssd-devel mailing list