[SSSD] [PATCH] Add mandatory flag to SSSD config schema

Jakub Hrozek jhrozek at redhat.com
Fri Feb 5 13:12:40 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/04/2010 09:20 PM, Stephen Gallagher wrote:
> On 01/11/2010 09:58 AM, Jakub Hrozek wrote:
>> On 01/07/2010 05:54 PM, Stephen Gallagher wrote:
>>> Address https://fedorahosted.org/sssd/ticket/349
> 
> 
>>> After a bit of thought, I decided to break this into two separate
>>> patches to make it more clear. New patches attached.
> 
>>> Patch 0002: Remove the explicit defaults where they're unneeded.
> 
>> Ack
> 

This patch is the same, so the ACK remains.

>>> Patch 0003: Implement the mandatory flag as in the previous patch.
> 
>> Nack,
> 
>> the schema adds ipa_hostname as mandatory service.
> 
>> Also all of the {access,auth,chpass,id}_providers are marked as
>> mandatory - is that correct? A domain with just id and auth providers is
>> a perfectly valid one.
> 
> I made chpass_provider and access_provider optional

The only glitch I found was that in order for the unittests to keep
working, you also need to remove chpass_provider and access_provider
from SSSDConfigTestSSSDDomain.testListMandatoryOptions()

The other changes look fine to me, and FTR, they are the only changes
versus the previous patch. The code looks fine to me.

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAktsGUgACgkQHsardTLnvCXEvgCguy15xJTSmBxXFEKWThJPPjR/
FuQAoJmhfQEv6lyrTNeCIw7pwFTvABf5
=ccyD
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list