[SSSD] [PATCH] Reactivate old fd handling conditionally

Stephen Gallagher sgallagh at redhat.com
Thu Feb 4 14:02:51 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/04/2010 08:15 AM, Sumit Bose wrote:
> Hi,
> 
> this path reintroduces the old way of handling the file description of a
> LDAP connection if the connection callback is not available.
> 
> Using the old way we cannot handle LDAP referrals and I think we should
> generate a DEBUG message if ldap_referrals is set to 'true' and add a
> hint to the man page. Do you agree?  I didn't put these changes in the
> patch to make the review easier because if can be compared line by line
> with commit 7c8f422495347e6ff829246ebf5d7faad9f6d160 'Use ldap
> connection callbacks to get file descriptors'.
> 
> bye,
> Sumit
> 

The patch looks fine. I'd like to see the man page specify that
ldap_referrals do not work for openldap libraries older than 2.4.12.

The debug message should reflect the same.

Please resubmit with these two changes.


- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAktq04sACgkQeiVVYja6o6OOuwCdGDpYQNYgRCrKlD8fq6WPFiGi
FEYAn1HWCbdPyiWJ+6Dm6qGbWBvZa5Gf
=f6sA
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list