[SSSD] [PATCH] Make krb5 and open checks work if forking is disabled

Sumit Bose sbose at redhat.com
Wed Feb 3 12:13:53 UTC 2010


Hi,

this patch fixes two unit tests which failed of CK_FORK is set to no.

bye,
Sumit
-------------- next part --------------
From 0b29ef6131e101b03e544722e3fc71568ef6ca54 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Tue, 2 Feb 2010 17:22:34 +0100
Subject: [PATCH] Make krb5 and open checks work if forking is disabled

---
 server/tests/check_and_open-tests.c |    5 ++++-
 server/tests/krb5_utils-tests.c     |    1 +
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/server/tests/check_and_open-tests.c b/server/tests/check_and_open-tests.c
index 2e96455..23bdb95 100644
--- a/server/tests/check_and_open-tests.c
+++ b/server/tests/check_and_open-tests.c
@@ -32,7 +32,8 @@
 
 #define SUFFIX ".symlink"
 
-char filename[] = "check_and_open-tests-XXXXXX";
+#define FILENAME_TEMPLATE "check_and_open-tests-XXXXXX"
+char *filename;
 uid_t uid;
 gid_t gid;
 mode_t mode;
@@ -42,6 +43,7 @@ void setup_check_and_open(void)
 {
     int ret;
 
+    filename = strdup(FILENAME_TEMPLATE);
     ret = mkstemp(filename);
     fail_unless(ret != -1, "mkstemp failed [%d][%s]", errno, strerror(errno));
     close(ret);
@@ -63,6 +65,7 @@ void teardown_check_and_open(void)
 
     fail_unless(filename != NULL, "unknown filename");
     ret = unlink(filename);
+    free(filename);
     fail_unless(ret == 0, "unlink failed [%d][%s]", errno, strerror(errno));
 }
 
diff --git a/server/tests/krb5_utils-tests.c b/server/tests/krb5_utils-tests.c
index c3d9f4c..8676f3b 100644
--- a/server/tests/krb5_utils-tests.c
+++ b/server/tests/krb5_utils-tests.c
@@ -92,6 +92,7 @@ void free_talloc_context(void)
     int ret;
     fail_unless(tmp_ctx != NULL, "Talloc context already freed.");
     ret = talloc_free(tmp_ctx);
+    tmp_ctx = NULL;
     fail_unless(ret == 0, "Connot free talloc context.");
 }
 
-- 
1.6.6



More information about the sssd-devel mailing list