[SSSD] [PATCHES] Split off helper libraries into their own packages

Dmitri Pal dpal at redhat.com
Tue Feb 2 00:11:17 UTC 2010


Stephen Gallagher wrote:
> Patches 0001-0003: License and package libpath_utils
>
01: In the header should the COPYING.lesser be COPYING.LESSER? Otherwise Ok.
02: Ok
03: I can' review this file I do not know the RPM syntax yet.

> Patches 0004-0007: License and package libcollection. (Patch 0005 fixes
> an incorrect #include in collection.h)
>
04: Seems Ok, but now I am confused. I thought we had both licenses on
the level above in "common", is this not enough? I thought we
investigated that this is enough. What has changed. Why we put them in
all places?
05: Is it just for cleanness of the interface? Seems ok if it compiles.
06: Seems Ok but I am not an expert. Second pair of eyes would not be
redundant. Should the -version-info 1:0:0 match the versions in the
configure.ac?
07: I can' review this file I do not know the RPM syntax yet.


> Patch 0008-0011: License and package libini_config. (Patch 0009 fixes an
> array index mistake that was throwing a compiler warning and would have
> been a potential memory-corruption bug.)
>
08: same as 04.
09: good catch, full ack
10: same as 06
11: same as 07

> Patch 0012-0014: License and package libref_array

12: same as 04
13: Seems Ok but I am not an expert. Second pair of eyes would not be
redundant. Should the -version-info 1:0:0 match the versions in the
configure.ac?
14: same as 07


Bottom line.
I do not see major issues with what I understand.
I have a dirty tree so I did not apply the patches.
If the patches apply, the version should not match (I suspect it should
not because something tells me that version-info might define the
version of the shared library interface) and someone checks the RPM
patches I think there will be a joint ack.
>
>
> These are all very simple patches, there are just a bunch of them :) It
> should be an easy review.
>

-------------------------

_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list