[SSSD] [PATCH] Fix segfault in pam_sss.so

Simo Sorce ssorce at redhat.com
Thu Dec 16 21:18:16 UTC 2010


On Thu, 16 Dec 2010 11:55:41 -0500
Stephen Gallagher <sgallagh at redhat.com> wrote:

> --- a/src/sss_client/pam_sss.c
> +++ b/src/sss_client/pam_sss.c
> @@ -413,7 +413,7 @@ static int do_pam_conversation(pam_handle_t
> *pamh, const int msg_style, }
>      } while (state != SSS_PAM_CONV_DONE);
>  
> -    *_answer = answer;
> +    if(answer) *_answer = answer;

FAIL-Style ^^^ there should be a space after the if :)

However it is not clear to me how this would prevent a segfault.

I think you meant it to be:
if (_answer) *_answer = answer;

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list