[SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgallagh at redhat.com
Tue Aug 31 11:11:34 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/31/2010 05:41 AM, Jakub Hrozek wrote:
> On 08/31/2010 09:59 AM, Jan Zelený wrote:
>> I'm attaching some patches fixing various minor issues found by clang:
> 
>> 0001-Initialized-return-value-in-dp_copy_options.patch
>> Ticket: #577
> 
> 
> ACK
> 
>> 0002-Fixed-potential-comparison-of-undefined-variable.patch
>> Ticket: #578
> 
> 
> ACK
> 
>> 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch
>> Ticket: #579
> 
> 
> Provided that it is safe to pass a NULL pointer to fprintf(), this is
> OK. I know that glibc handles this, but I'm not entirely sure if that it
> is good behaviour (if this would work with all possible optimalizations)
> and if other libc implementations behave the same as glibc.

This is a bug in e.g. the Intel compiler, if I remember correctly.
Please fix fprintf. I recommend using the construct:
name ? name : "";
in the fprintf call.

> 
>> 0004-Fixed-uninialized-value-in-proxy_id-provider.patch
>> Ticket: #580
> 
> 
> I guess NSS_STATUS_UNAVAIL is as good as any of the others in this case,
> so ACK
> 

I don't understand this comment, Jakub. Jan used NSS_STATUS_TRYAGAIN
here (which I think is certainly correct).

>> 0005-Deleted-some-needless-assignments.patch
>> Ticket: #582
> 
> 
> I think we should check for potential errors from sdap_id_op_done()
> calls instead of removing the assignments altogether.

I agree with Jakub. These assignments shouldn't be removed, they should
be tested for failures.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkx842YACgkQeiVVYja6o6N6zgCbBfJoA1NqW0Uhm7ik8gk/yNDZ
iYgAn0X/YOojmrWYsPI73FTwyrJK2Xbs
=kVke
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list