[SSSD] [PATCH] Add callback when the ID provider switches from offline to online

Stephen Gallagher stephen at gallagherhome.com
Thu Apr 29 11:41:16 UTC 2010


On 04/29/2010 05:52 AM, Sumit Bose wrote:
>> +
>> +static int online_cb_destructor(TALLOC_CTX *ptr);
>> +int be_add_online_cb(TALLOC_CTX *mem_ctx,
>> +                     struct be_ctx *ctx,
>> +                     be_conn_online_callback_t cb,
>> +                     void *pvt,
>> +                     struct be_conn_online_cb **online_cb)
>> +{
>> +    struct be_conn_online_cb *on_cb;
>> +
>> +    if (!ctx || !cb) {
>> +        return EINVAL;
>> +    }
>> +
>> +    on_cb = talloc(mem_ctx, struct be_conn_online_cb);
>> +    if (!online_cb) {
>>      
> if (!on_cb) ??
>
> bye,
> Sumit
>    
Thanks for catching that. When I added the **online_cb return, I changed 
the name of the internal struct to be on_cb, but I missed that use of 
it. That would have been a bug, since it would have returned on error if 
called without expecting a returned struct.

New patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-callback-when-the-ID-provider-switches-from-offl.patch
Type: text/x-patch
Size: 8995 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100429/47247c32/attachment.bin>


More information about the sssd-devel mailing list