[SSSD] [PATCH] Silence warnings with -O2

Stephen Gallagher sgallagh at redhat.com
Tue Apr 27 12:24:46 UTC 2010


On 04/27/2010 08:10 AM, Jakub Hrozek wrote:
> tools/sss_sync_ops.c: In function ‘groupmod’:
> tools/sss_sync_ops.c:262: warning: ‘member_dn’ may be used uninitialized
> in this function
> tools/sss_sync_ops.c: In function ‘usermod’:
> tools/sss_sync_ops.c:202: warning: ‘member_dn’ may be used uninitialized
> in this function
> tools/sss_sync_ops.c:201: warning: ‘attrs’ may be used uninitialized in
> this function
> - ---
>
> I think the ones in sss_sync_ops are spurious, but the others are legit.

>
>> Also, you're changing functionality here. For example, in
>> sdap_save_user(), by removing the 'goto fail' lines, we will no longer
>> print a DEBUG message on failure.
>>
>
> Ah, correct, especially in the sdap_save_user() case it would be confusing.
>
> A new patch is attached.

Ack.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list