[SSSD] [PATCH] fix early free of sdap_handle

Simo Sorce ssorce at redhat.com
Thu Apr 15 16:09:30 UTC 2010


On Thu, 15 Apr 2010 17:43:46 +0400
Eugene Indenbom <eindenbom at gmail.com> wrote:

> Because:
> 1. sdap_handle is not an opaque data structure. It's pointer is known
> to outside code which can accidentally call talloc_free. It's easier
> to allow calling talloc_free than to find all places where it is
> called. It also reduces amount of changed legacy code.
> 
> 2. I want to have regular talloc parent for all other sub-objects of 
> sdap_handle. This way we exclude from hierarchy only one memory
> block. This makes the solution more simple and robust.

Ok, you almost convinced me.

I will take another look at your patch and see if we can use it as a
base point.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list