[SSSD] [PATCH] Fix ini_config unit test

Dmitri Pal dpal at redhat.com
Wed Apr 14 15:38:40 UTC 2010


Stephen Gallagher wrote:
> When running 'make distcheck', the entire source directory is set
> to read-only, to ensure that the build process only has write
> access to $builddir. As a result, this was causing the unit test
> for file mode to fail, since the file it was testing resides in
> the $srcdir.
>
> This patch guarantees that the test file has the correct
> permissions prior to running the access test.
>
> This patch applies atop the ini metadata patches and should be pushed
> alongside them.
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
Why chmod done from the UT itself?
It seems that the build framework should probably take care of this and
this
should be enforced in make check in make rather that from UT source code.
At least that how such things have been done in the past. Is it a right
way of
doing such things? I just do not know...
IMO it seems it does not belong there but if this is how it is supposed
to be I will buy it. Do we need to check the result of the chmod and
exit if it failed?



-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list