[SSSD] [PATCH] Convert the example config to v2 format, upgrade config on update only

Jakub Hrozek jhrozek at redhat.com
Fri Sep 25 15:31:04 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/25/2009 05:12 PM, Stephen Gallagher wrote:
> Nack
> 
> The changes to sssd.spec.in are unnecessary. The upgrade_config.py
> already does an internal check and bails out if the version is already
> matched.
> 

I know there is a check in the script but I still think it is better to
not run the script at all if we know we are installing and not
upgrading. At least we don't output the "config file already v2" message
while having the message in the script for manual runs.

Anyway, I reverted the change in the specfile

> There's trailing whitespace after min_id in [domains/AD] (and it still
> is [domains/AD] instead of [domain/AD]

Thanks, fixed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkq84i4ACgkQHsardTLnvCU/SgCgjckOoZWnR657+UzH1IAkx92u
+KQAn2ln4vD67pL9MEe7yvXnrlKP4EPq
=Xfqb
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Convert-the-example-config-to-v2-format-upgrade-con.patch
Type: text/x-patch
Size: 6002 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090925/2a1449c4/attachment.bin>


More information about the sssd-devel mailing list