[SSSD] [PATCHES] Convert the SSSD to config_file_version 2

Jakub Hrozek jhrozek at redhat.com
Fri Sep 25 10:53:17 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/25/2009 12:22 PM, Stephen Gallagher wrote:
> Actually, I would prefer that we use this tool for potential future
> upgrades (that I hope never to have...). It would be better for it to
> detect which version is currently in place and upgrade it from 1 to 2,
> then 2 to 3, etc. internally and then write out the current version.
> 
> This way we don't need to change the spec file again for that, as well.
> 

OK

>> >
>>> >> - when using '-f /somewhere/my.conf' the backup is created in /somewhere
>>> >>   but the new config is written to /etc/sss/sssd.conf. My expectation was
>>> >>   that the conversion would be done in-place. If you prefer it this way
>>> >>   '--help' should say that the default output file is
>>> >>   /etc/sss/sssd.conf
>> >
>> >
>> > Fixed, thanks
> Uh, this doesn't look right to me:
> +    if options.filename and not options.outfile:
> +        options.outfile = options.filename
> +    if not options.outfile:
> +        options.outfile = '/etc/sssd/sssd.conf'
> 
> I think that second if needs to be elif, otherwise you're always going
> to override setting options.outfile = options.filename
> 

D'oh..

the logic is fixed (note the default options are /etc/sssd/sssd.conf and
None respectively)


	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkq8oRIACgkQHsardTLnvCUuCwCgvcn9+gY3Gh0bilm+qklnCKxu
6yIAn3fCviXVrHQDLmUou2oG1j8u5koy
=sT+j
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-script-to-upgrade-config-to-v2.patch
Type: text/x-patch
Size: 17130 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090925/20e45d29/attachment.bin>


More information about the sssd-devel mailing list