[SSSD] [PATCH] Use syslog for logging error conditions in SSSD

Stephen Gallagher sgallagh at redhat.com
Mon Sep 21 10:39:35 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/21/2009 05:58 AM, Jakub Hrozek wrote:
> On 09/21/2009 11:12 AM, Jakub Hrozek wrote:
>>> I'll propose another patch.
>>>>
>> attached
> 
> Uff, sorry, forgot to remove a test syslog statement in useradd, yet
> another patch attached.
> 
> Also please note that b/c the patch touches the tools, it needs to be
> applied on top of the three big patches under review.
> 
> 	Jakub

I have only one issue with this patch.  There's no reason to touch every
one of the sss_tools with 'int send_syslog = 1'. None of the tools call
any of the functions that would invoke SYSLOG_ERROR or SYSLOG_WARN until
after the sss_tools_init() call, so it seems to me that this would be a
better common location to do it.
- ------------------------------------------------------------------------

_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkq3V+IACgkQeiVVYja6o6OzAACfQ8BjAuu53SCawg8OIkyjlURD
ByIAoKMQ/WKGlj7FrhhJN+CxWEA9WVhO
=3Etp
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list