[SSSD] [PATCHES] python bindings for managing users in local domains

Stephen Gallagher sgallagh at redhat.com
Fri Sep 18 14:26:58 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/14/2009 05:27 PM, Jakub Hrozek wrote:
> On 09/14/2009 10:54 PM, Simo Sorce wrote:
>> If it will not take you too much time it would be nice to have them
>> straightened :)
> 
>> If you think it will take too long to fix, just let me know and I'll
>> just push them together.
> 
>> Simo.
> 
> 
> git add -i to the rescue!
> 
> The attached patches also fix a conflict in Makefile.am between them &
> one of the recent kerberos patches.
> 
> 	Jakub

Patch 0001: Ack
Patch 0002:

usermod(), useradd(), etc.: res should be a talloc child of req. (Also,
in the current implementation, if user_mod_send returned NULL for
ENOMEM, you would leak res)

user_mod_send(), group_mod_send: subreq should be a talloc child of req.
If for some reason we cancelled the request for usermod, we want to make
sure that its subrequests aren't continuing.

There's a lot of code duplication in user_mod_*. Is it possible to code
this in such a way that you only have one common callback that processes
the results and kicks off another request if needed?


Patch 0003: Left to John to review

- ------------------------------------------------------------------------

_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqzmK8ACgkQeiVVYja6o6Pw/QCeIL8g/wiWeldCHY9m1w/mc42P
vyIAn2o3JcPA/EHJADp9BljNfYd2VjVs
=91fg
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list