[SSSD] [PATCH] Add support for the EntryCacheNoWaitRefreshTimeout

Sumit Bose sbose at redhat.com
Wed Sep 9 12:46:21 UTC 2009


On Tue, Sep 08, 2009 at 08:32:55PM -0400, Stephen Gallagher wrote:
> I have refactored nsssrv_cmd.c and created a new patch for the
> EntryCacheNoWaitRefreshTimeout.
> 
> I have created a new function, check_cache() which is a common entry
> point for getpwnam, getpwuid, getgrnam and getgrgid to examine whether
> the cache is still valid.
> 
> Addressing other points from the review inline below.
> 
> 
> On 08/17/2009 11:19 AM, Sumit Bose wrote:
> > On Fri, Aug 14, 2009 at 03:46:54PM -0400, Stephen Gallagher wrote:
> >> This timeout specifies the lifetime of a cache entry before it is
> >> updated out-of-band. When this timeout is hit, the request will
> >> still complete from cache, but the SSSD will also go and update
> >> the cached entry in the background to extend the life of the
> >> cache entry and reduce the wait time of a future request.
> >>
> >> Support for the EnumCacheNoWaitRefreshTimeout is still forthcoming, but
> >> I wanted to get a formal review on this portion.
> > 
> > 
> > NACK. I think this patch indicates that nsssrv_cmd.c needs some
> > refactoring, please do this before adding more code.
> > 
> 
> Done.
> 

hmm, I must force myself not to use debugging option while testing
patches ...

I have seen this one:
....
responder/nss/nsssrv_cmd.c: In function 'nss_cmd_getgrnam_callback':
responder/nss/nsssrv_cmd.c:1728: warning: unused variable 'cache_ctx'
....

bye,
Sumit



More information about the sssd-devel mailing list