[SSSD] [PATCH] Split database file to one per domain

Stephen Gallagher sgallagh at redhat.com
Tue Sep 8 19:04:41 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/08/2009 02:11 PM, Simo Sorce wrote:
> On Tue, 2009-09-08 at 13:04 +0200, Sumit Bose wrote:
>> The patches apply and compile cleanly and are working for me. I have
>> done some very limited upgrade tests and they worked, too. On the
>> downside, make check fails, but so far I don't know why, there might
>> be
>> a problem on my side.
> 
> No it was my fault, I changed the tests to just open the "local" domain
> now, and to create a directory where to run the tests and pass it as
> DB_PATH to sysdb_domain_init().
> 
>> Please find my comments further down in the code, but most of them can
>> be addressed by later patches. So,
> 
> Replying to in code comments here:
> - I'd like to wait some more to split sysdb.c, in general I'd like to
> reorganize sysdb files better later on, perhaps moving also the
> sysdb_search.c
> - I commented sysdb_read_var() because it is not used anymore, but I
> didn't want to loose that code just yet.
> In this new patch I removed it.
> - Ok reworked variable names and declaration to abide to style guide.
> (thanks for this one I found a bug when I renamed l and p to count and
> pos)
> - I haven't use mkstemp because the backup is performed in a root only
> writable directory, so there is no security risk (and we use O_CREAT
> too). Also I wanted a recognizable file name, not something that looked
> like a random temp file that can be deleted.
> - I don't think handling mmap is going to be faster/slower than using a
> buffer, plus, we don't care as this is a once only operation, plus the
> code is done, so I don't see reason to change it now :)
> 
>> ACK, if you remove the tabs from the patch.
> 
> Yes fixed tabs too.
> 
> Simo.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Ack

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqmqskACgkQeiVVYja6o6Pg1wCfSO4MldeI5G6Mon7vYYETy/PU
iUAAn29AVwZrgbLJ7p8j9c7vmRa6PByP
=LWBY
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list