[SSSD] [PATCH] COLLECTION Copy collection flat with concatenated names

Jakub Hrozek jhrozek at redhat.com
Mon Sep 7 14:05:21 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/05/2009 02:32 AM, Dmitri Pal wrote:
> See patch comment.
> This patch most likely will not apply cleanly without my previous ELAPI
> patches.
> So far it is 4 th pending patch.
> More to come.

In general, I think the patch is OK. Some comments, though:

* col_copy_traverse_handler got pretty long, one function now accounts
for more that 200 lines doing different things, esp. with different copy
mode handling. Maybe it would be more readable if it was split into
smaller ones?

* the copy mode could be made unsigned (or even enum copy_mode {...}),
you wouldn't have to test for mode<0

* if you really need assigning const* to non-const*, can you just use
something like the discard_const_p macro in server/util/util.h, I think
it's way better that memcpy-ing the memory

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqlEyEACgkQHsardTLnvCUX9ACfQ1Y2XZqsqukSZD72IPilJNxq
dqoAoMGhB5/3AR+NnW6pysEQtt/23rhA
=bQMa
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list