[SSSD] [PATCH] ELAPI Adding file provider and CSV format

Stephen Gallagher sgallagh at redhat.com
Fri Sep 4 16:22:42 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/02/2009 08:27 PM, Dmitri Pal wrote:
> Hi,
> 
> This patch is next significant chunk of code.
> See patch comments for the main description.
> It requires previous patch that has been reviewed but was not pushed yet.
> It addresses some of the suggestions risen during the review.
> I also added couple tickets: to eventually remove all the "Fixme"
> comments and to refactor places where I allocated context structs and
> initialize them.
> 
> Checked with make check, valgrind and did in tree and parallel builds.
> All works, no leaks.
> 
> Sorry that it is too big.
> I need to move on and there are many things that are still missing.
> I will start working on  the next set of the functionality tomorrow
> mainly adding async processing. That would definitely affect some of the
> arguments passed all along so expect changes to many modules.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Nack.

Please do not use a #define when you really mean "typedef"

you probably wanted
typedef struct elapi_data_out {
    char *buffer;
    uint32_t size;
    uint32_t length;
    uint32_t written;
} SEDO;

But I still don't much care for SEDO. But this is an internal-only
header so I'm not going to complain too loudly. That said, we generally
frown upon using typedef anywhere but function pointers, since they
obfuscate the actual type you're using. I'd much prefer if you used
"struct elapi_data_out" written out fully.

This is the only problem I see in a high-level overview of this code.
Jakub was going to do a more in-depth review, so I'll wait on his
comments as well.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqhPs4ACgkQeiVVYja6o6OvZQCghjLrKssZBe9OoJvtauXtyxBP
xGkAnjxgAPNbKsCz3/cc0k3hpnKeZtk0
=EWYP
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list