[SSSD] [RFC][PATCH] adding domain-type config option

Simo Sorce ssorce at redhat.com
Thu Sep 3 13:11:20 UTC 2009


On Thu, 2009-09-03 at 08:47 -0400, Dmitri Pal wrote:
> Sumit Bose wrote:
> > Hi,
> >
> > this patch is work in progress, please do not push it to the master
> > repository.
> >
> > I think it makes sense to introduce meta-options which can set more than
> > on option at once. As an example I have implemented a 'domain-type'
> > option which will set a couple of option for an IPA domain at once. To
> > handle more than one meta-option this patch needs a bit more
> > abstraction, but I would like to get some feedback on the general idea.

> Get_values is not freed in one of the error paths in set_domain_defaults().

We should actually avoid to free them all over the function, we should
rather create e tmp_ctx at the start of the function and do one single
talloc_free(tmp_ctx) at the end.
That's what talloc is useful for.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list