[SSSD] [PATCH] fix offline auth

Stephen Gallagher sgallagh at redhat.com
Thu Oct 15 11:45:15 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/15/2009 04:12 AM, Sumit Bose wrote:
> On Wed, Oct 14, 2009 at 07:59:54PM -0400, Simo Sorce wrote:
>> Offline authentication got broken when we removed the Data Provider.
>> Before the bug was masked by the DP itself, so it became evident only
>> when DP has been removed.
>>
>> Simo.
>>
> 
> This patch applies and works well and fixes #224.
> 
> ACK,
> 
> but please fix
> 
> responder/pam/pamsrv_cmd.c: In function 'pam_check_user_dp_callback':
> responder/pam/pamsrv_cmd.c:560: warning: unused variable 'res'
> 
> before pushing to master.

Fixed and pushed to master.

> 
> Btw is it ok to remove pam_shutdown and nss_shudown?

Yes, these functions should have been removed when the DP was removed.
They existed as part of the reconnection code to the DP. (If the
responders couldn't reconnect, they would shut down and let the monitor
start everything up again from a clean state)

> 
> bye,
> Sumit
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkrXC0oACgkQeiVVYja6o6PuFACeJKNHuyH0eszDKN3koKY5e+lZ
z38An0L8yYF8JMNQ9HBfGmyKjHYeS5BW
=vLUI
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list