[SSSD] [PATCH] Fix error messages in tools

Jakub Hrozek jhrozek at redhat.com
Mon Oct 12 09:03:49 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/06/2009 08:29 PM, Stephen Gallagher wrote:
> Nack after all. Jenny noticed that there are some places where the
> returned error code should be nonzero and it is not.
> 
> Please fix these up and resubmit.

I looked at the test cases and I think the error codes actually were
nonzero (they were value of errno) but the tests check for ret == 1
because we usually use EXIT_FAILURE as return code.

Anyway, I think it should be fixed. Is it possible to run the test
battery on an RPM with this patch again?

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkrS8PUACgkQHsardTLnvCVFowCfUmvmzwveYPSry4b9F4/8YQj1
qDEAnAwQyItr0lcjxNNmTZkSxobR7FbF
=Ihyd
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-error-messages-in-tools.patch
Type: text/x-patch
Size: 21999 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091012/9ad93019/attachment.bin>


More information about the sssd-devel mailing list