[SSSD] [PATCH] Remove mpg option

Sumit Bose sbose at redhat.com
Fri Oct 9 19:54:33 UTC 2009


On Wed, Oct 07, 2009 at 04:40:21PM -0400, Simo Sorce wrote:
> On Tue, 2009-10-06 at 13:16 -0400, Stephen Gallagher wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On 10/06/2009 12:16 PM, Simo Sorce wrote:
> > > See subj and patch comment.
> > > 
> > > Simo.
> > > 
> > > 
> > > ------------------------------------------------------------------------
> > > 
> > > _______________________________________________
> > > sssd-devel mailing list
> > > sssd-devel at lists.fedorahosted.org
> > > https://fedorahosted.org/mailman/listinfo/sssd-devel
> > 
> > I'm unclear why you needed to do anything besides remove the
> > get_entry_as_bool(CONFDB_DOMAIN_MPG) section.
> > 
> > What's the advantage to moving the mpg bool into the sysdb_ctx instead
> > of the sss_domain_info object? It seems to me that this is an attribute
> > of the domain more than the sysdb.
> 
> It's an attribute of the db now, in theory we could even just remove the
> bool completely and always check if we are accessing the local provider
> db.
> 
> Simo.
> 

I think it make sense to have it as a DB attribute and I would prefer to
keep the attribute around.

ACK

bye,
Sumit



More information about the sssd-devel mailing list