[SSSD] [PATCH] fix nested groups

Simo Sorce ssorce at redhat.com
Mon Nov 30 13:52:56 UTC 2009


On Mon, 2009-11-30 at 07:44 -0500, Simo Sorce wrote:
> On Mon, 2009-11-30 at 11:47 +0100, Sumit Bose wrote:
> > On Fri, Nov 27, 2009 at 07:13:55PM -0500, Simo Sorce wrote:
> > > When I did the enumgrent optimization patch I totally forgot about
> > > nested groups for some reason.
> > > Of course I broke them. The gain in performance although was just way
> > > too substantial to just revert to the previous way of resolving nested
> > > groups again and again at every search.
> > > 
> > > These 2 patches instead store unrolled groups by adding a new
> > > operational attribute: memberuid
> > > This attribute contains just the user name of any user directly or
> > > indirectly (through a nested group) members of a group.
> > > This way computation is done once at modify time and never again.
> > > 
> > > Fixes bug #291
> > > 
> > > Simo.
> > > 
> > 
> > 0001 does not compile:
> > 
> > ldb_modules/memberof.c: In function 'memberof_del':
> > ldb_modules/memberof.c:1152: error: 'el' undeclared (first use in this
> > function)
> > ldb_modules/memberof.c:1152: error: (Each undeclared identifier is
> > reported only once
> > ldb_modules/memberof.c:1152: error: for each function it appears in.)
> 
> I will check, builds and tests fine here.
> 
> > Do I miss another patch which fixes this?

Ok, I think I forgot to send the attached patch first.
And 0001 probably didn't apply cleanly to your tree to get that error.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-tabs.patch
Type: text/x-patch
Size: 4396 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091130/5c1e3a91/attachment.bin>


More information about the sssd-devel mailing list