[SSSD] [PATCH] Cleanups

Martin Nagy mnagy at redhat.com
Sat Nov 7 01:48:00 UTC 2009


Simo Sorce wrote:
> This patch adds some cleanups and fixes coding style deviations.
> There are some more in the resolve code.

You added braces to if constructs. I was under the impression that we
shouldn't use them for one line statements [1]. Personally, I find it
more readable without them, but if the general consensus is to use them
then someone should update the coding style. Same goes for one liners
like:

+        if (err) return err;

Martin

[1] http://freeipa.org/page/Coding_Style#IF_Statements



More information about the sssd-devel mailing list