[SSSD] [PATCH] Build files.c only for tools

Simo Sorce ssorce at redhat.com
Thu Nov 5 19:01:04 UTC 2009


On Thu, 2009-11-05 at 13:16 -0500, Stephen Gallagher wrote:
> Ask, and receive.
> 
> On 11/05/2009 11:51 AM, Simo Sorce wrote:
> > On Thu, 2009-11-05 at 08:14 -0500, Stephen Gallagher wrote:
> >> Addresses https://fedorahosted.org/sssd/ticket/257
> >>
> >> On Ubuntu and other platforms that build with
> >> LDFLAGS=-Wl,-Bsymbolic-files, we would fail to link the sssd binary
> >> successfully, because files.o would have unresolved dependencies
> since
> >> we don't link agsinst the SELinux library.
> >>
> >> There were two options to fix this:
> >> 1) Link against -lselinux. I rejected this because the sssd monitor
> >> binary does not in fact use any of the features of files.o at this
> >> time.
> >> It didn't make sense to introduce an additional, unused library
> >> dependency.
> >>
> >> 2) Only link files.o (and SELinux) where needed. At this time, that
> >> means only the command line tools. This is the approach I took.
> >>
> >> If, in the future, we decide to add some of the files.c
> functionality
> >> to
> >> other places in the SSSD, we can carry it in and link against
> SELinux
> >> at
> >> that time.
> > 
> > I would suggest to move the file under server/tools then.
> > 
> > Simo.

ACK

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list