[SSSD] [PATCH] Build the elapi_test suite without extra autoconf invocation

Stephen Gallagher stephen at gallagherhome.com
Thu Nov 5 01:02:11 UTC 2009


There's no rush to include it. I'd been thinking about how to correct
that for a while, and I finally got around to doing so.

I'm fine with holding off on applying it until your next set of
patches come through.

On Nov 4, 2009, at 7:59 PM, Dmitri Pal <dpal at redhat.com> wrote:

> Stephen Gallagher wrote:
>> There's no need to have a separete configure.ac and Makefile.am
>> for the elapi_test directory. By creating test-specific helper
>> libraries, we can alter the CFLAGS for just the tests. This will
>> speed up builds, as we do not need to run configure on an extra
>> directory. It will also mean only one Makefile to keep in sync
>> with source code changes.
>>
>>
>
> I generally like the idea. This is something I was looking for when I
> was trying to develop UT
> in the first place. Good that it is possible since what we have now is
> definitely a hack.
> I am reluctant to give it an Ack right away though.
> Two reasons. One I want to try it but my code is a mess now it does
> not
> build because
> I am in the middle of a set of major patches. I started them last week
> and you have seen some of them.
> I hoped I will be able to add some hours to it while I am in CA but
> I am
> really exhausted after a working
> day here since I have meetings with different people most part of
> the day.
> Second reason is that this patch will add a bit more burden to my
> mess.
> So is there any way to hold it a bit until I get to a more stable
> state?
> If it is so urgent to apply it, then sure, you have approval from me
> (if
> someone else actually
> applies and tries it). If you want me to try it, please give me some
> time.
>
>
>
>> ---
>> ---------------------------------------------------------------------
>>
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel at lists.fedorahosted.org
>> https://fedorahosted.org/mailman/listinfo/sssd-devel
>
>
> --
> Thank you,
> Dmitri Pal
>
> Engineering Manager IPA project,
> Red Hat Inc.
>
>
> -------------------------------
> Looking to carve out IT costs?
> www.redhat.com/carveoutcosts/
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list