[SSSD] [PATCH] always return error in unknown cases

Stephen Gallagher sgallagh at redhat.com
Fri Dec 18 18:16:41 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/18/2009 01:06 PM, Simo Sorce wrote:
> Be defensive, it's better to return an error than potentially allow
> something for operations you know nothing about.
> 
> Simo.
> 

Nack.
This may break session handling, which right now gets sent to
be_pam_handler() and falls into the default case (since we don't do
anything during the session stack).

We need to properly receive session-open and session-close and return
PAM_SUCCESS.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAksrxwkACgkQeiVVYja6o6P01QCglSaif61n9UMIDhuVeGMlWLDd
bSgAn2bLO2BK/MCMBnjRTyWfevntXiie
=8o/1
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list