[SSSD] [PATCH] Handle chauthtok with PAM_PRELIM_CHECK separately

Stephen Gallagher sgallagh at redhat.com
Thu Dec 17 18:09:56 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/16/2009 08:31 AM, Sumit Bose wrote:
> On Wed, Dec 16, 2009 at 02:03:44PM +0100, Sumit Bose wrote:
>> On Wed, Dec 16, 2009 at 01:04:01PM +0100, Sumit Bose wrote:
>>> Hi,
>>>
>>> this patch should fix #326 "Missing checks in PAM_PRELIM_CHECK"
>>>
>>> Currently we collect old and new password in pam_sss and send them
>>> together to the sssd to change to password. But it is expected that
>>> during the first call to pam_sm_chauthtok, when PAM_PRELIM_CHECK is set,
>>> the old password is validated to give a feedback to the user before the
>>> new password is requested.
>>>
>>> Please check and test carefully.
>>>
>>> bye,
>>> Sumit
>>
>> aaahh, sorry, I found a flaw in the changes for the Kerberos provider.
>>
>> Please wait for a new version ...
>>
> 
> ok, new version attached, I also added Tomas suggestion.
> 
> bye,
> Sumit
> 


Looks fine except for

             break;
+            break;
         default:
             DEBUG(1, ("Unsupported PAM task.\n"));
             return NULL;


The extra break here is unnecessary.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAksqc/QACgkQeiVVYja6o6NggwCfVfkrLNJoWBPr4v0ognKzumYu
ifwAnRk7/8u50LSxfk/q1f5h7rZrmX1I
=wYs8
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list