[SSSD] [PATCH] dhash: add private pointer for delete callback

Dmitri Pal dpal at redhat.com
Tue Dec 8 18:58:47 UTC 2009


Simo Sorce wrote:
> On Tue, 2009-12-08 at 13:26 -0500, John Dennis wrote:
>   
>> On 12/08/2009 01:08 PM, Simo Sorce wrote:
>>     
>>> A delete callback may need to get information beyond the single hash
>>> entry. Pass in a private pointer so the caller can pass whatever private
>>> context to the delete callback.
>>>
>>> Simo.
>>>       
>> Am I missing something? This doesn't address Dmitri's issue.
>>     
>
> It does indirectly.
> Now that you have a private pointer you can easily add data in there to
> tell the next hash_delete what it should do with the data.
>
> Simo.
>
>   
Patch makes sense but I think you need to update the comments in the
header to describe the use of the private context parameter.

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list