[SSSD] [PATCH] ipa_access offline support

Stephen Gallagher sgallagh at redhat.com
Mon Dec 7 12:45:15 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/30/2009 04:58 AM, Sumit Bose wrote:
> Hi,
> 
> I realized that although all attributes are saved the offline support
> the for ipa_access module was not present. These two patches should fix it.
> 
> 0001 adds a general search request for custom attributes

Ack

> 0002 adds sysdb calls to ipa_access if the provider is offline

Nack.

The memory allocation in msgs2attrs_array() looks wrong to me.

You shouldn't be allocating an array into *a. You're overwriting it (and
leaking memory) when you allocate a single sysdb_attrs pointer for a[i]
anyway (and it would be correct there)

Otherwise it looks fine.

> 
> bye,
> Sumit
> 

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAksc+NcACgkQeiVVYja6o6O7GACdHqSSis86WG+U36/BreiuoWw1
b5IAn1HRfWS42youFrkyko0JHtsd4Uqp
=MSGY
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list