[SSSD] [PATCH] fix nested groups

Simo Sorce ssorce at redhat.com
Wed Dec 2 21:22:18 UTC 2009


On Fri, 2009-11-27 at 19:13 -0500, Simo Sorce wrote:
> When I did the enumgrent optimization patch I totally forgot about
> nested groups for some reason.
> Of course I broke them. The gain in performance although was just way
> too substantial to just revert to the previous way of resolving nested
> groups again and again at every search.
> 
> These 2 patches instead store unrolled groups by adding a new
> operational attribute: memberuid
> This attribute contains just the user name of any user directly or
> indirectly (through a nested group) members of a group.
> This way computation is done once at modify time and never again.
> 
> Fixes bug #291

Thanks to Sumit and some tests he is building it turned out this
patchset wasn't working correctly.

There were 2 problems.
1. an old standing bug we didn't catch earlier. It was causing some
memberof attributes from not being deleted when an entry was deleted or
a membership removed. Because the memberuid patch piggybacked on some of
the memberof deletes to know what to do, memberuid deletion also didn;t
behave properly.

2. A minor bug of its own in the memberuid patch.

Attached find:
0001 fix the old memberof bug
0002 New memberuid patch for memberof
0003 Rebased patch to use memberuid in enumerations
0004 Rebased patch (and fixed description) patch to use custom password
field


Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-memberof-plugin.patch
Type: text/x-patch
Size: 2159 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091202/f76d71a7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Compute-and-save-memberuid-in-cache-as-well.patch
Type: text/x-patch
Size: 46179 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091202/f76d71a7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Use-memberuid-and-not-member-in-group-enumerations.patch
Type: text/x-patch
Size: 6202 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091202/f76d71a7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Use-the-custom-password-field-in-groups-too.patch
Type: text/x-patch
Size: 1899 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091202/f76d71a7/attachment-0003.bin>


More information about the sssd-devel mailing list