[SSSD] [PATCH] fix DBusWatch handling

Stephen Gallagher sgallagh at redhat.com
Mon Aug 31 19:10:31 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/31/2009 02:47 PM, Simo Sorce wrote:
> On Thu, 2009-08-27 at 00:35 -0400, Simo Sorce wrote:
>> After some playing around with Stephen patch and adding some debugging I
>> finally understood how DBUS likes to deal with watches.
>>
>> We erroneously assumed that DBUS would add only one watch per FD.
>> It doesn't, instead it always adds 2 watches.
>> One to catch read events and one to catch write events.
>>
>> It then proceed to always keep one of the 2 disabled when the other is
>> enabled, and it always toggles both when it needs to reverse access to
>> the file descriptor.
>>
>> The following patch keeps track of sbus-watches/fd pairs and allocate
>> both DBusWatches to the same structure.
>>
>> So far testing seem to confirm this approach works as expected.
> 
> New revision.
> 
> I was finally able to test this patch on an Ubuntu machine (thanks
> Steve) and we found out 2 pretty nasty bugs masquerading each other on
> Fedora.
> 
> This new revision should be final, it works on Ubuntu and on Fedora.
> 
> Simo.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Ack and pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqcICcACgkQeiVVYja6o6PT5QCgnXsS6aeKeOgov1BpMTLiE9Qz
bpQAn2R/oG62agKgRx3Cxq8WwSWimsEc
=/qv8
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list